Skip to content

Cleanup offload datatransfer#151640

Open
ZuseZ4 wants to merge 4 commits intorust-lang:mainfrom
ZuseZ4:cleanup-datatransfer
Open

Cleanup offload datatransfer#151640
ZuseZ4 wants to merge 4 commits intorust-lang:mainfrom
ZuseZ4:cleanup-datatransfer

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Jan 25, 2026 •
edited
Loading

There are 3 steps to run code on a GPU: Copy data from the host to the device, launch the kernel, and move it back.
At the moment, we have a single variable describing the memory handling to do in each step, but that makes it hard for LLVM's opt pass to understand what's going on. We therefore split it into three variables, each only including the bits relevant for the corresponding stage.

cc @jdoerfert @kevinsala

r? compiler

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2026
@ZuseZ4 ZuseZ4 added the F-gpu_offload `#![feature(gpu_offload)]` label Jan 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
ZuseZ4
ZuseZ4 commented Jan 25, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch 2 times, most recently from d9def93 to 4f29cbe Compare January 25, 2026 09:57
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch 2 times, most recently from 014d61d to 6b45680 Compare January 25, 2026 23:32
@ZuseZ4 ZuseZ4 marked this pull request as ready for review January 26, 2026 03:47
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2026
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Jan 26, 2026

I don't think jieyouxu will want to review this part of rustc.
r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned jieyouxu Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

@rust-bors

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch from 6b45680 to 1c28bd8 Compare January 29, 2026 22:16
@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch from 1c28bd8 to c310bf7 Compare January 29, 2026 22:51
@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch from c310bf7 to b2b51e4 Compare January 29, 2026 23:09
@ZuseZ4 ZuseZ4 mentioned this pull request Feb 2, 2026
Open
5 tasks
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Feb 2, 2026

@rustbot reroll

@rustbot rustbot assigned nnethercote and unassigned oli-obk Feb 2, 2026
@rust-lang rust-lang deleted a comment from rustbot Feb 2, 2026
@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch from b2b51e4 to 3fb0092 Compare February 2, 2026 04:20
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@ZuseZ4 ZuseZ4 force-pushed the cleanup-datatransfer branch from 3fb0092 to 446bd1d Compare February 2, 2026 04:21
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Feb 2, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   6 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/double_parens.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/eager_transmute.rs ... ok
---
...............................................    (147/147)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: Error: The window properties still all match: for command `wait-for-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Feb 2, 2026 •
edited
Loading

spurious failure, cc @jieyouxu
I think the doc ones fail somewhat often, lately? But I couldn't find this one in the open issues.

@RalfJung RalfJung mentioned this pull request Feb 2, 2026
Open
@RalfJung
Copy link
Member

RalfJung commented Feb 2, 2026

There's an issue at #93784.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-gpu_offload `#![feature(gpu_offload)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZuseZ4 @rust-log-analyzer @rustbot @RalfJung @oli-obk @nnethercote @jieyouxu